fix add_default_workflow #3446
Open
fix add_default_workflow #3446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FWIW, this was tested in qiita via a terminal and it works as expected. |
charles-cowart
requested changes
Dec 17, 2024
| @@ -989,7 +999,7 @@ def _get_predecessors(workflow, node): | |||
| init_artifacts = { | |||
| wkartifact_type: f'{starting_job.id}:'} | |||
| else: | |||
| init_artifacts = {wkartifact_type: self.artifact.id} | |||
| init_artifacts = {wkartifact_type: str(self.artifact.id)} | |||
There was a problem hiding this comment.
I hate to say it but having to cast an internal id to string is a little bit concerning to me. Internal code should use the numeric form of the artifact_id and it should also be easy to pass the numeric version for any REST call. May I ask why this is needed? I feel like even if it's needed, it would be much clearer to cast it right before it's used to make it obvious why it's needed. Sorry if that's not clear.
| @@ -871,7 +881,7 @@ def _get_predecessors(workflow, node): | |||
| 'artifact transformation'] | |||
| merging_schemes = { | |||
| qdb.archive.Archive.get_merging_scheme_from_job(j): { | |||
| x: y.id for x, y in j.outputs.items()} | |||
| x: str(y.id) for x, y in j.outputs.items()} | |||
There was a problem hiding this comment.
The conversion to string for y.id is also not obvious here. Perhaps a comment as to why it's necessary would be appropriate?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.